anmol-saxena-14 commented on code in PR #1968:
URL: https://github.com/apache/activemq/pull/1968#discussion_r3265019317
##########
pom.xml:
##########
@@ -967,7 +969,7 @@
<forkCount>1</forkCount>
<reuseForks>false</reuseForks>
<forkedProcessTimeoutInSeconds>${surefire.forkedProcessTimeout}</forkedProcessTimeoutInSeconds>
- <enableProcessChecker>all</enableProcessChecker>
+
<enableProcessChecker>${surefire.enableProcessChecker}</enableProcessChecker>
Review Comment:
Yes, that is exactly what this change does.
Before, the value was hardcoded inline in the surefire plugin configuration:
`<enableProcessChecker>all</enableProcessChecker>`
After, it is driven by a Maven property with **all** as the default:
**`<!-- in <properties> -->`**
`<surefire.enableProcessChecker>all</surefire.enableProcessChecker>`
**`<!-- in surefire plugin config -->`**
`<enableProcessChecker>${surefire.enableProcessChecker}</enableProcessChecker>`
The default value is unchanged so CI and all existing environments behave
identically. The only difference is that a developer on Windows 11 (where wmic
is no longer available) can now override it on the command line without
patching the pom:
`mvn test -Dsurefire.enableProcessChecker=ping`
This change follows the same pattern already used in this pom for
`surefire.forkedProcessTimeout` and `surefire.argLine`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
