cshannon commented on PR #2019: URL: https://github.com/apache/activemq/pull/2019#issuecomment-4615385216
> @cshannon Interesting! I like how your approach sort of 'auto adjusts' for most workflows. > > I think ultimately a ExpiryStrategy/ExpiryPolicy interface would be best to encapsulate different desired behaviors across policy entries and destination types. > > For workflows that specifically _do not_ to do any expiry checking, an unequivocal flag (like @mwashburn2 has proposed) to disable entirely is probably useful at the very least. > > Also, for hot-spot performance testing with Virtual Threads we'll want to be able to toggle choke points that enter some sort of synchronization or 0(n) processing (think: parameterized unit tests to toggle cache, producerAudit, expiry, etc). Adding something to turn if off entirely but I think both things should be done to help out the default case. Even with an expiration policy to turn it off, most people are not going to know to do that so I think the strategy I proposed makes sense for the default case and could be added easily. With a fast abort like I proposed, there's likely not going to be much need for most people to turn it off as they won't notice it being slow. Also there's obviously the situation where people do expect expired messages but rarely, and would prefer to not have to pay the performance penalty if the expiration isn't common. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
