cshannon commented on PR #2138: URL: https://github.com/apache/activemq/pull/2138#issuecomment-4779705165
> @cshannon before this change, any time a non-zero maxUncommittedCount value was used, error was thrown when using network connector to transfer messages. > > If you run the unit test from this PR on an unpatched tree, you’ll get the error when sending a number of non-transacted messages beyond the maxUncommittedCount Thanks, I looked at the test and saw the javadoc which I think explains it well, I will add to the PR is the following: >Prior to the fix, network-forwarded messages (which have a null transactionId) caused a NullPointerException in TransactionBroker.verifyUncommittedCount() when maxUncommittedCount was set to a positive value. Running the test is fine and yes I can review the change and figure out what is going on, but keep in mind we are documenting for the users as well. Someone who upgrades will get release notes and want to know what changed and why and isn't going to have a clue without a description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
