cshannon opened a new pull request, #2188: URL: https://github.com/apache/activemq/pull/2188
This fixes the rare null body issues seen on the broker when using text messages by using synchronization when marshaling or unmarshaling the body into a String to prevent a race condition from causing the body to end up null. This has been optimized to use volatiles and double checked locking to avoid synchronization unless needed. For some background, this has been a long running issue that has come up over the years and there have been many proposed ways to fix it (see #1851 and #1659 for examples). Despite the fact that these messages are supposed to be copied and not used across multiple threads there are cases where that is not true and can cause issues (topic consumers on dispatch for example don't copy) so this issue still pops up from time to time. After looking at all the options and how disruptive it would be, **I think this is the best approach for now as a short term fix**. I think long term we could look at better solutions. I think ideally on the server side it would be nice to use messages that only store the data in the marshaled format as the vast majority of the the time the body should not need to be unmarshaled anyways (exceptions include protocol conversion or logging). The client versions could still use mutable messages that can store either version. **Work still todo:** 1. This PR only attempts to fix the body for ActiveMQTextMessage. This is a problem for the body of other message types as well (including Map, object message, etc) and separate PRs can be opened to fix those if others agree on this strategy. 2. A PR will need to be done to ensure that the properties map is synchronized as well because it has the same potential problem where the state can be mutated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
