mattrpav commented on PR #2197:
URL: https://github.com/apache/activemq/pull/2197#issuecomment-4918800677

   > I also have concerns that this could page in a lot more into memory and 
cause a huge memory spike if you are using count before full. The default 
prefetch is 32k and obviously that should be tuned but it could cause a large 
increase in paged in messages if there are a lot of consumers even with a 
prefetch not that high
   
   Note: queuePrefetch default is 1,000, but yeah the overall concern is valid.
   
   Its an odd scenario and it looks like it trips up on the somewhat side-ways 
logic.
   
   memoryUsage: has space
   sum of consumer prefetch: has space
   maxPageSize: less than the number of paged in messages.
   
   The conditional comparing current pending count vs pageSize is a context 
switch in the comparison logic. Smells like an apples-to-oranges type deal 
rotating around counts vs space in memory usage.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to