cshannon commented on code in PR #2199: URL: https://github.com/apache/activemq/pull/2199#discussion_r3551574171
########## activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java: ########## Review Comment: I just realized that this method can throw an exception. If that happens, the counter gets incremented but it would never be decremented so I think that needs to be fixed too. We might just need a separate try/catch to wrap pendingSends.increment if we need to increment before checkUsage. I haven't looked at the producerExchange.incrementSend() but i am wondering if that is a problem too with missing decrement on exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
