mattrpav commented on code in PR #2231:
URL: https://github.com/apache/activemq/pull/2231#discussion_r3617922717
##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/MessageDatabase.java:
##########
@@ -3893,8 +3915,12 @@ class MessageOrderIterator implements
Iterator<Entry<Long, MessageKeys>>{
final Iterator<Entry<Long, MessageKeys>>highIterator;
final Iterator<Entry<Long, MessageKeys>>defaultIterator;
final Iterator<Entry<Long, MessageKeys>>lowIterator;
+ // when false, next() leaves the shared
lastDefaultKey/lastHighKey/lastLowKey
+ // bookmarks untouched so this iteration cannot affect the
destination cursor
+ final boolean trackLastKeys;
- MessageOrderIterator(Transaction tx, MessageOrderCursor m,
MessageOrderIndex messageOrderIndex) throws IOException {
+ MessageOrderIterator(Transaction tx, MessageOrderCursor m,
MessageOrderIndex messageOrderIndex, boolean trackLastKeys) throws IOException {
Review Comment:
Latest commit 68eea73c71e581ad1c3804a3ed3ba1726276ce57 applies these changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
