cshannon commented on PR #2206: URL: https://github.com/apache/activemq/pull/2206#issuecomment-5036960391
@mattrpav and @jbonofre - the more I think about it, the more I think the better fix is to just not catch Error at all. We literally don't catch Error anywhere else, what are the odds this is the exact spot it fails? I have no idea why this is the _one_ spot we would try and catch it. If we really want to handle Errors we should do it at a much higher level to handle errors anywhere else in the broker, and that is a much bigger scope outside of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
