arimu1 opened a new pull request, #2270:
URL: https://github.com/apache/activemq/pull/2270

   ## Summary
   
   `ConnectionView.getWireFormatInfo()` called 
`getRemoteWireFormatInfo().toString()` without a null check. 
`TransportConnection.wireFormatInfo` is only set after wire-format negotiation, 
so reading the JMX attribute earlier (or for transports that never set it) 
threw a `NullPointerException`.
   
   This change returns the existing `"WireFormatInfo not available"` 
placeholder when the remote `WireFormatInfo` is null, matching the 
non-`TransportConnection` path.
   
   Fixes #2203
   
   ## Changes
   
   - `ConnectionView.getWireFormatInfo()`: null-safe remote `WireFormatInfo` 
handling
   - `ConnectionViewTest`: regression coverage for present and null remote info
   
   ## Test plan
   
   - [x] `mvn -pl activemq-broker test -Dtest=ConnectionViewTest` (JDK 17)
     - `testGetWireFormatInfoWhenPresent`
     - `testGetWireFormatInfoWhenRemoteInfoNull`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to