mattrpav commented on code in PR #1543:
URL: https://github.com/apache/activemq/pull/1543#discussion_r4073359306
##########
activemq-client/src/main/java/org/apache/activemq/command/ActiveMQObjectMessage.java:
##########
@@ -290,8 +290,15 @@ public void initTransients() {
}
@Override
- public boolean isBodyAssignableTo(Class c) throws JMSException {
- final Serializable object = getObject();
+ public boolean isBodyAssignableTo(Class c) {
+ final Serializable object;
+ try {
+ object = getObject();
+ } catch (JMSException e) {
Review Comment:
Do we also need to catch JMSRuntimeException here? Perhaps maybe a comment
that if the exception types get refactored to be JMSRuntimeException-first this
is a spot that needs special handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
