mattrpav commented on code in PR #1853:
URL: https://github.com/apache/activemq/pull/1853#discussion_r4074557587
##########
activemq-client/src/main/java/org/apache/activemq/command/ActiveMQMessage.java:
##########
@@ -501,6 +515,15 @@ public void setObjectProperty(String name, Object value,
boolean checkReadOnly)
checkValidObject(value);
value = convertScheduled(name, value);
+
+ // Strict Compliance Check For Provider-Set JMSX Properties
+ ActiveMQConnection conn = getConnection();
+ if (conn != null && conn.isStrictCompliance()) {
+ if (STRICT_PROVIDER_JMSX_PROPERTIES.contains(name)) {
+ throw new JMSException("Provider-set JMSX property '" + name +
"' cannot be set by a client under strict compliance.");
Review Comment:
Please update this exception to throw MessageNotWriteableException to be
spec-aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
