cshannon commented on PR #2402: URL: https://github.com/apache/activemq/pull/2402#issuecomment-5782781441
> @cshannon, the way I see jmx_exporter, is that it provides a way to make and use a mapping of MBean attributes to metrics, but doesn't provide a mapping, so nothing works out of the box. This is the pain point I'm trying to solve, I just see this Prometheus servlet as the easiest path to fixing that problem. I'm committed to maintaining it. > @hai-ben - I guess I am not understanding how this solves a pain point and is the easiest path forward because the end of the day, the MBean attributes have to be mapped for prometheus in some fashion, whether by writing code like this PR or by writing yaml for the JMX exporter. Besides requiring writing a lot of code to do the mapping and export manually, this PR also hard codes all the attributes so if new attributes are needed to be added it requires a code change and is not flexible. With the JMX exporter, a configuration file is provided and that's it. It's very flexible and uses regular expressions so new metrics can be mapped and picked up automatically or just require a simple config change. It's easy to maintain and update and most people are very familiar with it as it's very common in the Java ecosystem. There's probably already plenty of examples online if we google for ActiveMQ. Honestly you could probably just use an AI model to generate one in a few minutes. So, really I'm just trying to see the benefit of this approach vs the JMX exporter because I still don't see one but maybe I am missing something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
