jbonofre opened a new pull request, #2657:
URL: https://github.com/apache/activemq/pull/2657

   Related to #2238 (flaky test cleanup, 
`VirtualConsumerDemandTest.testToTopicWithDurable:1358`).
   
   `VirtualConsumerDemandTest.testToTopicWithDurable` (and `testToTopic`, seen 
failing on `main` at line 1281) occasionally fails on CI at 
`bridgeConsumer.receive(5000)`: the message never reaches the remote durable 
subscriber. I could not reproduce it locally (640 runs under CPU load on JDK 
21), and ruled out two theories:
   
   - `waitForConsumerCount` is not satisfied prematurely: the local consumer 
count is 0 until the durable's demand propagates.
   - The bridge registers the demand subscription in `subscriptionMapByLocalId` 
before creating the local consumer, so it cannot drop the first message.
   
   This PR is **diagnostics only, not a fix**. On a receive timeout it now 
fails with a dump of:
   
   - the `include.*` destinations on both brokers, with their statistics and 
subscriptions
   - the bridge statistics and demand subscriptions
   
   so the next CI flake shows where the message was lost (local topic, bridge, 
or remote composite/durable). Test behaviour is otherwise unchanged. The helper 
replaces the 8 `assertNotNull(bridgeConsumer.receive(5000))` calls in this 
class.
   
   Verified locally: all 16 `testTo*` runs pass, and a forced timeout prints 
the expected dump.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to