cshannon commented on PR #2402:
URL: https://github.com/apache/activemq/pull/2402#issuecomment-6236825909

   > @cshannon
   > 
   > You're right that the mapping has to be written either way, and that 
unlike hardcoding a mapping, a YAML does expose new attributes without a code 
change. And I agree that the actual writing and maintaining a yaml is not a 
heavy technical lift for users, but it can be a business/logistical/compliance 
pain to deploy jmx_exporter alongside or expose Jolokia in the broker.
   > 
   > The way I see it, this is the stable set of core metrics for ActiveMQ, 
vended without requiring users to inject 3rd party executables into or expose 
RMI surface area on their broker. As for maintenance concern, all but 2 of the 
MBean attributes coded in this PR (`TotalQueuesCount` and `TotalTopicsCount` 
added in 6.2) have existed unchanged since 2015.
   
   That's fair enough, there will be more metrics coming but it can be updated. 
Having this as a separate plugin is fine as it's optional to enable and doesn't 
stop people from using alternatives like the jmx exporter. I was just curious 
of the use case and why. Having something native without an external dependency 
is certainly easier to set up.
   
   6.4.0 release is wrapping up now, so this can go into 6.5.0 (and it looks 
like it's already tagged with 6.5.0) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to