tabish121 commented on PR #2770:
URL: https://github.com/apache/activemq/pull/2770#issuecomment-6617725716

   > Oops so I reviewed this too quickly and I got it backwards. This is doing 
the opposite of what I thought, so this probably is a good change, after all.
   > 
   > @tabish121 - Any thoughts on this? At first glance this seems like a good 
idea.
   
   Issue seems real as using `allocateDirect` outside of a pooled use case is 
generally not great. The direct memory buffer can't be freed as it could be in 
something like a netty pool where the buffer is reference counted and you can 
release it once done using it.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to