Syphdias commented on PR #2791:
URL: https://github.com/apache/activemq/pull/2791#issuecomment-6669729682

   > you confirm that the default Docker image works, right?
   
   yes
   
   > You have an issue when setting a malformed env variable: in that case, the 
Docker container doesn't start and no error is displayed.
   
   No, in the case of malformated `ACTIVEMQ_JMX_PASSWORD` (one that ends with a 
newline) leads to `sed: unmatched '/'` because busybox's sed does not like 
newlines (in `s`).
   
   ```
   $ busybox sed 's/hello
   /hi /' <<< 'hello
   world'
   sed: unmatched '/'
   ```
   
   In this case I would want it to crash because the password will not have 
been replaced and is still literal "activemq" and thus unsecured.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to