mattrpav commented on issue #2604: URL: https://github.com/apache/activemq/issues/2604#issuecomment-6866663713
Changes to existing calls in JL's producer completion listener PR and this PR, compared with `main`: | Change | Existing call affected | On `main` | With JL's PR | Notes | |---|---|---|---|---| | Producer send rules | `send(Destination, Message)` on a producer created with that destination | Works | `UnsupportedOperationException` | #2604 makes this apply only when `strictCompliance` is on. 16 test files were edited here to drop the destination argument. | | Producer send rules | `send(Message)` on a producer created without a destination | `InvalidDestinationException` | `UnsupportedOperationException` | #2604 makes this apply only when `strictCompliance` is on | | Delivery mode and priority validation | `send(...)` with an explicit delivery mode and priority | Priority restricted to 0-9, an unknown delivery mode sent as non-persistent | `JMSException` | Always on | | Close or stop from a `MessageListener` | `Connection.close()`, `Connection.stop()`, `Session.close()` | Works | `IllegalStateException` | Always on. Two tests in `JMSConsumerTest` were changed for this. | | Shared consumer argument checks | `createSharedConsumer` and `createSharedDurableConsumer` with a null topic or a bad selector | `InvalidDestinationException` or `InvalidSelectorException` | `UnsupportedOperationException` | Checks removed in 2e571dd358 | The `CompletionListener` sends, `setAsync` and `getAsync` threw `UnsupportedOperationException` before, so they are new and not listed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
