jcamachor commented on a change in pull request #769: HIVE-22194 Break up DDLSemanticAnalyzer - extract Privilege related analyzers URL: https://github.com/apache/hive/pull/769#discussion_r323981124
########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java ########## @@ -28,21 +28,21 @@ import org.apache.hadoop.hive.metastore.api.PrincipalType; import org.apache.hadoop.hive.ql.ErrorMsg; import org.apache.hadoop.hive.ql.ddl.DDLWork; -import org.apache.hadoop.hive.ql.ddl.privilege.CreateRoleDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.DropRoleDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.GrantDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.GrantRoleDesc; import org.apache.hadoop.hive.ql.ddl.privilege.PrincipalDesc; import org.apache.hadoop.hive.ql.ddl.privilege.PrivilegeDesc; import org.apache.hadoop.hive.ql.ddl.privilege.PrivilegeObjectDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.RevokeDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.RevokeRoleDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.SetRoleDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.ShowCurrentRoleDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.ShowGrantDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.ShowPrincipalsDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.ShowRoleGrantDesc; -import org.apache.hadoop.hive.ql.ddl.privilege.ShowRolesDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.grant.GrantDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.revoke.RevokeDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.create.CreateRoleDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.drop.DropRoleDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.grant.GrantRoleDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.revoke.RevokeRoleDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.set.SetRoleDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.show.ShowRolesDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.role.showcurrent.ShowCurrentRoleDesc; +import org.apache.hadoop.hive.ql.ddl.privilege.show.grant.ShowGrantDesc; Review comment: Maybe we can merge them under `show` package (but not too strongly opinionated about it, up to you). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
