kgyrtkirk commented on a change in pull request #819: HIVE-22363 ReduceDeduplication may leave an invalid GroupByOperator behind in some cases URL: https://github.com/apache/hive/pull/819#discussion_r337506882
########## File path: ql/src/test/results/clientpositive/llap/explainuser_1.q.out ########## @@ -4990,38 +4990,44 @@ Vertex dependency in root stage Reducer 2 <- Map 1 (SIMPLE_EDGE) Reducer 3 <- Reducer 2 (SIMPLE_EDGE) Reducer 4 <- Reducer 3 (SIMPLE_EDGE) +Reducer 5 <- Reducer 4 (SIMPLE_EDGE) Review comment: I have to say that I was not expecting these changes - in this case the "grouping of key2/key3" is removed; so I'm not sure in the absencce of those columns from partitioning the GBY will work as expected.... I've attached a screenshot from the diff where the changes could be seen better:  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
