scarlin-cloudera commented on a change in pull request #812: Hive 22324
URL: https://github.com/apache/hive/pull/812#discussion_r338637814
 
 

 ##########
 File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java
 ##########
 @@ -741,7 +741,7 @@ public static RewritablePKFKJoinInfo 
isRewritablePKFKJoin(Join join,
     final RelNode nonFkInput = leftInputPotentialFK ? join.getRight() : 
join.getLeft();
     final RewritablePKFKJoinInfo nonRewritable = 
RewritablePKFKJoinInfo.of(false, null);
 
-    if (joinType != JoinRelType.INNER) {
+    if (joinType != JoinRelType.INNER && !join.isSemiJoin()) {
 
 Review comment:
   This is called only from HiveJoinConstraintsRule, please see comment there 
and let's discuss.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to