miklosgergely commented on a change in pull request #866: HIVE-22536 Improve
return path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r358325740
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
// 0. Gen Optimized Plan
RelNode newPlan = logicalPlan();
- if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP))
{
+ if (ReturnPathManager.shouldUse()) {
if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
Review comment:
Ok, I see it now. Is it the plan not to use RP for view creation ever? In
this case we must keep the non return path way at the end?
Or is it the case, that eventually we'll use RP for view creation as well?
Because in this case we can add the exclusion of view creation to the
ReturnPathManager to return false in case of "supported" for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
