vineetgarg02 commented on a change in pull request #938: HIVE-22978
URL: https://github.com/apache/hive/pull/938#discussion_r390027730
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTypeSystemImpl.java
##########
@@ -148,4 +172,17 @@ public boolean isSchemaCaseSensitive() {
return false;
}
+ @Override
+ public RelDataType deriveSumType(RelDataTypeFactory typeFactory,
Review comment:
Can you add a comment explaining why is this being done? Adding 10 seems
arbitrary without the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
