anishek commented on a change in pull request #951: HIVE-22997 : Copy external
table to target during Repl Dump operation
URL: https://github.com/apache/hive/pull/951#discussion_r395573595
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestReplDumpTask.java
##########
@@ -127,13 +128,15 @@ public void
removeDBPropertyToPreventRenameWhenBootstrapDumpOfTableFails() throw
private int tableDumpCount = 0;
@Override
- void dumpTable(String dbName, String tblName, String validTxnList, Path
dbRoot, Path replDataDir,
- long lastReplId, Hive hiveDb, HiveWrapper.Tuple<Table>
tuple)
+ List<EximUtil.ReplPathMapping> dumpTable(String dbName, String tblName,
String validTxnList, Path dbRoot,
+ Path replDataDir, long
lastReplId, Hive hiveDb,
+ HiveWrapper.Tuple<Table> tuple)
throws Exception {
tableDumpCount++;
if (tableDumpCount > 1) {
throw new TestException();
}
+ return Collections.EMPTY_LIST;
Review comment:
better to use Collections.emptyList() here and other places, the generic
cast would be provided by this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
