odraese commented on a change in pull request #944: [Hive-22760] Adding Clock
based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r395921046
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java
##########
@@ -80,9 +80,32 @@ int tryIncRef() {
return incRefInternal(false);
}
+ /**
Review comment:
More of a general comment: Ths LlapAllocatorBuffer is getting more and more
"helper data" and methods, which are specific to one eviction policy. The
buffer should just be a buffer and if the eviction policy needs additional
information, it should wrap the buffer by itself. We might want to clean this
up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
