aasha commented on a change in pull request #963: HIVE-23020 : Avoid using
_files for replication data copy during incr…
URL: https://github.com/apache/hive/pull/963#discussion_r401522879
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -505,9 +506,8 @@ private static ImportTableDesc
getBaseCreateTableDescFromTable(String dbName,
Task<?> copyTask = null;
if (replicationSpec.isInReplicationScope()) {
- boolean isImport =
ReplicationSpec.Type.IMPORT.equals(replicationSpec.getReplSpecType());
copyTask = ReplCopyTask.getLoadCopyTask(replicationSpec, dataPath,
destPath, x.getConf(),
- isAutoPurge, needRecycle, copyToMigratedTxnTable, !isImport);
+ isAutoPurge, needRecycle, copyToMigratedTxnTable, false);
Review comment:
Why is this set to false? Do we even need this boolean if everyone is
setting it to false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
