prasanthj commented on a change in pull request #964: HIVE-23095 ndv 70
URL: https://github.com/apache/hive/pull/964#discussion_r405679222
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/ndv/hll/HLLSparseRegister.java
##########
@@ -148,8 +148,12 @@ public int encodeHash(long hashcode) {
}
}
- public int getSize() {
- return sparseMap.size() + tempListIdx;
+ public boolean isSizeGreaterThan(int s) {
+ if (sparseMap.size() + tempListIdx > s) {
+ mergeTempListToSparseMap();
Review comment:
also can we remove fastutil dependency? For such small encoding switch
threshold I don't think fastutils fast hashmap implementation is worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
