belugabehr commented on a change in pull request #1029: URL: https://github.com/apache/hive/pull/1029#discussion_r434953975
########## File path: beeline/src/java/org/apache/hive/beeline/Commands.java ########## @@ -1063,13 +1057,17 @@ private boolean executeInternal(String sql, boolean call) { showRemainingLogsIfAny(stmnt); } } + if (rs != null) { + rs.close(); Review comment: Closing the result set can throw a `SQLException` in which case it will skip over the `Statement#close()` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org