kgyrtkirk commented on a change in pull request #1031:
URL: https://github.com/apache/hive/pull/1031#discussion_r438057083
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java
##########
@@ -392,10 +392,11 @@ private static String getName(GenericUDF hiveUDF) {
registerFunction("istrue", SqlStdOperatorTable.IS_TRUE,
hToken(HiveParser.Identifier, "istrue"));
registerFunction("isnotfalse", SqlStdOperatorTable.IS_NOT_FALSE,
hToken(HiveParser.Identifier, "isnotfalse"));
registerFunction("isfalse", SqlStdOperatorTable.IS_FALSE,
hToken(HiveParser.Identifier, "isfalse"));
- registerFunction("is not distinct from",
SqlStdOperatorTable.IS_NOT_DISTINCT_FROM, hToken(HiveParser.EQUAL_NS, "<=>"));
Review comment:
the calcite2hive translation was not working - and thrown an exception
I'm not sure about hive2calcite ; I've made a note on HIVE-23594 to check
out what was happening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
