kgyrtkirk commented on a change in pull request #1071:
URL: https://github.com/apache/hive/pull/1071#discussion_r438901224
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -13317,6 +13325,10 @@ public int markScheduledExecutionsTimedOut(int
timeoutSecs) throws InvalidOperat
recoverInvalidScheduledQueryState(timeoutSecs);
committed = commitTransaction();
return results.size();
+ } catch (InvalidOperationException | MetaException e) {
+ throw e;
+ } catch (Exception e) {
+ throw new MetaException(e.getMessage());
Review comment:
are these catches needed?
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -12872,15 +12879,16 @@ public int deleteRuntimeStats(int maxRetainSecs)
throws MetaException {
return 0;
}
boolean committed = false;
- try {
+ try (Query q = pm.newQuery(MRuntimeStat.class)) {
openTransaction();
int maxCreateTime = (int) (System.currentTimeMillis() / 1000) -
maxRetainSecs;
- Query q = pm.newQuery(MRuntimeStat.class);
q.setFilter("createTime <= maxCreateTime");
q.declareParameters("int maxCreateTime");
long deleted = q.deletePersistentAll(maxCreateTime);
committed = commitTransaction();
return (int) deleted;
+ } catch (Exception e) {
+ throw new MetaException(e.getMessage());
Review comment:
is this catch needed?
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -13272,15 +13280,16 @@ public int deleteScheduledExecutions(int
maxRetainSecs) {
return 0;
}
boolean committed = false;
- try {
+ try (Query q = pm.newQuery(MScheduledExecution.class)) {
openTransaction();
int maxCreateTime = (int) (System.currentTimeMillis() / 1000) -
maxRetainSecs;
- Query q = pm.newQuery(MScheduledExecution.class);
q.setFilter("startTime <= maxCreateTime");
q.declareParameters("int maxCreateTime");
long deleted = q.deletePersistentAll(maxCreateTime);
committed = commitTransaction();
return (int) deleted;
+ } catch (Exception e) {
Review comment:
is this catch needed?
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -13339,5 +13351,6 @@ private void recoverInvalidScheduledQueryState(int
timeoutSecs) {
pm.makePersistent(e);
}
}
+ q.closeAll();
Review comment:
use try-with-resources in this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
