pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r439263287
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -824,6 +839,12 @@ public void alterTable(String catName, String dbName,
String tblName, Table newT
throw new HiveException("Unable to alter table. " + e.getMessage(), e);
} catch (TException e) {
throw new HiveException("Unable to alter table. " + e.getMessage(), e);
+ } finally {
+ if (txnOpened) {
+ if (SessionState.get().getTxnMgr().isTxnOpen()) {
+ SessionState.get().getTxnMgr().commitTxn();
Review comment:
Here you commit the TXN, but we commit the txn at the end of the query
as well at Driver.releaseLocksAndCommitOrRollback(). I do not like that we
commit the transaction here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
