aasha commented on a change in pull request #1110:
URL: https://github.com/apache/hive/pull/1110#discussion_r441361483
##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -1534,10 +1534,10 @@
<column name="RM_DUMP_EXECUTION_ID" jdbc-type="bigint"
allows-null="false"/>
</field>
<field name="metadata">
- <column name="RM_METADATA" jdbc-type="varchar" allows-null="true"/>
+ <column name="RM_METADATA" jdbc-type="varchar" length="4000"
allows-null="true"/>
Review comment:
There are null checks present already at persistence layer
if (!StringUtils.isEmpty(replicationMetric.getMetadata())) {
mReplicationMetrics.setMetadata(replicationMetric.getMetadata());
}
if (!StringUtils.isEmpty(replicationMetric.getProgress())) {
mReplicationMetrics.setProgress(replicationMetric.getProgress());
}
And json serialization handles null
Code from json serializer
/**
* The method to be called by {@link ObjectMapper} and {@link
ObjectWriter}
* for serializing given value, using serializers that
* this provider has access to (via caching and/or creating new
serializers
* as need be).
*/
public void serializeValue(JsonGenerator gen, Object value) throws
IOException
{
_generator = gen;
if (value == null) {
_serializeNull(gen);
return;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
