kishendas commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r443062585
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -824,6 +836,7 @@ public void alterTable(String catName, String dbName,
String tblName, Table newT
throw new HiveException("Unable to alter table. " + e.getMessage(), e);
} catch (TException e) {
throw new HiveException("Unable to alter table. " + e.getMessage(), e);
+ } finally {
Review comment:
Rebased with master and only kept relevant changes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -795,7 +806,8 @@ public void alterTable(String catName, String dbName,
String tblName, Table newT
// Take a table snapshot and set it to newTbl.
AcidUtils.TableSnapshot tableSnapshot = null;
if (transactional) {
- if (replWriteId > 0) {
+
+ if (inReplication(newTbl) && replWriteId > 0) {
Review comment:
Rebased with master and only kept relevant changes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -905,6 +921,7 @@ public void alterPartition(String catName, String dbName,
String tblName, Partit
throw new HiveException("Unable to alter partition. " + e.getMessage(),
e);
} catch (TException e) {
throw new HiveException("Unable to alter partition. " + e.getMessage(),
e);
+ } finally {
Review comment:
Rebased with master and only kept relevant changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
