draese commented on a change in pull request #1150:
URL: https://github.com/apache/hive/pull/1150#discussion_r443185298
##########
File path: ql/src/java/org/apache/hadoop/hive/llap/LlapHiveUtils.java
##########
@@ -48,18 +50,27 @@ private LlapHiveUtils() {
// Not to be used;
}
- public static CacheTag getDbAndTableNameForMetrics(Path path, boolean
includeParts,
- Map<Path, PartitionDesc> parts) {
-
- assert(parts != null);
+ /**
+ * Takes path and a map of partition descs, returns the entry associated
with the given path.
Review comment:
This comment could be optimized. The logic isn't really explained well
and that parameter description doesn't help much either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
