deniskuzZ commented on a change in pull request #1151:
URL: https://github.com/apache/hive/pull/1151#discussion_r444698989
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecDriver.java
##########
@@ -148,8 +148,7 @@ public void setOperationId(String operationId) {
@Override
public CommandProcessorResponse run() throws CommandProcessorException {
executionIndex = 0;
- int maxExecutuions = 1 +
coreDriver.getConf().getIntVar(ConfVars.HIVE_QUERY_MAX_REEXECUTION_COUNT);
-
+ int maxExecutions = getMaxExecutions();
Review comment:
I also do not like this approach as you are aggregating all the
conditions from underlying plugins here (when adding new plugin you should
incorporate it's config here as well). What you could do is to define default
shouldReExecute method under IReExecutionPlugin, in this case new plugin would
use that or has to override it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
