pvary commented on a change in pull request #1166:
URL: https://github.com/apache/hive/pull/1166#discussion_r444741159



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -2994,12 +3005,13 @@ Seems much cleaner if each stmt is identified as a 
particular HiveOperation (whi
         break;
       case DDL_SHARED:
         compBuilder.setSharedRead();
-        if (!output.isTxnAnalyze()) {
+        if (output.isTxnAnalyze()) {
           // Analyze needs txn components to be present, otherwise an aborted 
analyze write ID
           // might be rolled under the watermark by compactor while stats 
written by it are
           // still present.
-          compBuilder.setOperationType(DataOperationType.NO_TXN);
+          continue;

Review comment:
       With using 'continue' we do not execute the code after the case 
statement. Is this intentional?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to