pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r444748978
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java
##########
@@ -681,11 +681,11 @@ public void testAcidInsertWithRemoveUnion() throws
Exception {
}
String[][] expected2 = {
- {"{\"writeid\":1,\"bucketid\":536870913,\"rowid\":0}\t1\t2",
"warehouse/t/delta_0000001_0000001_0001/bucket_00000_0"},
- {"{\"writeid\":1,\"bucketid\":536870913,\"rowid\":1}\t3\t4",
"warehouse/t/delta_0000001_0000001_0001/bucket_00000_0"},
- {"{\"writeid\":1,\"bucketid\":536870914,\"rowid\":0}\t5\t6",
"warehouse/t/delta_0000001_0000001_0002/bucket_00000_0"},
- {"{\"writeid\":1,\"bucketid\":536870914,\"rowid\":1}\t7\t8",
"warehouse/t/delta_0000001_0000001_0002/bucket_00000_0"},
- {"{\"writeid\":1,\"bucketid\":536870915,\"rowid\":0}\t9\t10",
"warehouse/t/delta_0000001_0000001_0003/bucket_00000_0"}
+ {"{\"writeid\":2,\"bucketid\":536870913,\"rowid\":0}\t1\t2",
"warehouse/t/delta_0000002_0000002_0001/bucket_00000"},
+ {"{\"writeid\":2,\"bucketid\":536870913,\"rowid\":1}\t3\t4",
"warehouse/t/delta_0000002_0000002_0001/bucket_00000"},
+ {"{\"writeid\":2,\"bucketid\":536870914,\"rowid\":0}\t5\t6",
"warehouse/t/delta_0000002_0000002_0002/bucket_00000"},
+ {"{\"writeid\":2,\"bucketid\":536870914,\"rowid\":1}\t7\t8",
"warehouse/t/delta_0000002_0000002_0002/bucket_00000"},
+ {"{\"writeid\":2,\"bucketid\":536870915,\"rowid\":0}\t9\t10",
"warehouse/t/delta_0000002_0000002_0003/bucket_00000"}
Review comment:
In the code the previous comment contains the expected directory/file
structure. We should fix that as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]