pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r444754446
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -12308,16 +12303,99 @@ else if(ast.getChild(0).getType() ==
HiveParser.TOK_FALSE) {
// if phase1Result false return
return false;
}
+
+ // 5. Set write id for HMS client
+ if (getTxnMgr().supportsAcid() &&
conf.get(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY) == null) {
Review comment:
I would be more comfortable, if we do not set writeId stuff in the HMS
client, but push the info to the client on another codepath using the conf, or
other parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
