pvary commented on a change in pull request #1081:
URL: https://github.com/apache/hive/pull/1081#discussion_r446784234
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -1605,6 +1618,46 @@ public int compareTo(CompressedOwid other) {
throw e; // rethrow the exception so that the caller can handle.
}
}
+
+ /**
+ * Create delete delta reader. Caching orc tail to avoid FS lookup/reads
for repeated scans.
+ *
+ * @param deleteDeltaFile
+ * @param conf
+ * @param fs FileSystem
+ * @return delete file reader
+ * @throws IOException
+ */
+ private Reader getDeleteDeltaReader(Path deleteDeltaFile, JobConf conf,
FileSystem fs) throws IOException {
+ OrcTail deleteDeltaTail =
deleteDeltaOrcTailCache.getIfPresent(deleteDeltaFile);
Review comment:
Is the OrcTail thread safe? If I understandcorrectly the tail will be
read by multiple LLAP threads concurrenly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
