pvary commented on a change in pull request #1095:
URL: https://github.com/apache/hive/pull/1095#discussion_r446842444
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -435,8 +439,14 @@ public void releaseLocksAndCommitOrRollback(boolean
commit, HiveTxnManager txnMa
}
// If we've opened a transaction we need to commit or rollback rather than
explicitly
// releasing the locks.
- driverContext.getConf().unset(ValidTxnList.VALID_TXNS_KEY);
-
driverContext.getConf().unset(ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY);
+ // Unset all the keys
+ for (String key : new String[] { ValidTxnList.VALID_TXNS_KEY,
ValidTxnWriteIdList.VALID_TABLES_WRITEIDS_KEY,
+ ValidTxnList.COMPACTOR_VALID_TXNS_ID_KEY,
ValidTxnWriteIdList.COMPACTOR_VALID_TABLES_WRITEIDS_KEY }) {
Review comment:
Why do we need the COMPACTOR_VALID_TABLES_WRITEIDS_KEY in the conf? I
would remove it if it is not strictly necessary.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -366,13 +368,16 @@ private void acquireLocks() throws
CommandProcessorException {
driverContext.getTxnManager().getTableWriteId(t.getDbName(),
t.getTableName());
}
-
Review comment:
Still one extra line is here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
