adesh-rao commented on a change in pull request #1109:
URL: https://github.com/apache/hive/pull/1109#discussion_r449486010
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
##########
@@ -1788,6 +2082,58 @@ public void addPartitionToCache(String catName, String
dbName, String tblName, P
}
}
+ public void addPrimaryKeysToCache(String catName, String dbName, String
tblName, List<SQLPrimaryKey> keys) {
+ try {
+ cacheLock.readLock().lock();
Review comment:
This is fine, the below method (cachePrimaryKeys), takes the writeLock.
the read lock here, is just to get the tblWrapper object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
