dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-654678113
> I don't see the need for this....what's wrong with [afterexecute](https://github.com/apache/hive/blob/e4256fc91fe2c123428400f3737883a83208d29e/ql/src/java/org/apache/hadoop/hive/ql/Executor.java#L533) or [failurehooks](https://github.com/apache/hive/blob/e4256fc91fe2c123428400f3737883a83208d29e/ql/src/java/org/apache/hadoop/hive/ql/Executor.java#L521)? > do you have a use case which could not be handled by those? The oom hook holds a hiveserver2 instance, which calls hiveserver2::stop() to end hiveserver2 gracefully, which would cleanup the session directory/scratch directory/operation log and so on . Although the hooks in the driver can handle oom, he may not be able to stop the hiveserver2 gracefully as the oom hook does. Sometimes we may want to dump the heap for futher analysis when oom happens or alter the devops, so it may be better to make the oom hook here an interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
