pvary commented on a change in pull request #1224:
URL: https://github.com/apache/hive/pull/1224#discussion_r451472066
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
##########
@@ -730,7 +729,10 @@ public boolean validateInput(FileSystem fs, HiveConf conf,
? AcidOperationalProperties.parseString(txnProperties) : null;
String value = conf.get(ValidWriteIdList.VALID_WRITEIDS_KEY);
- writeIdList = value == null ? new ValidReaderWriteIdList() : new
ValidReaderWriteIdList(value);
+ writeIdList = new ValidReaderWriteIdList(value);
+
+ value = conf.get(ValidTxnList.VALID_TXNS_KEY);
+ validTxnList = new ValidReadTxnList(value);
Review comment:
Will this help, if we have multiple partitions with multiple files to
parse the TxnList only once?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
