pvary commented on a change in pull request #1216:
URL: https://github.com/apache/hive/pull/1216#discussion_r452031376
##########
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List<byte
[]> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the
line at the ',' instead of adding a new concatenation?
##########
File path:
itests/qtest-druid/src/main/java/org/apache/hive/kafka/SingleNodeKafkaCluster.java
##########
@@ -175,24 +165,20 @@ public void createTopicWithData(String topic, List<byte
[]> events) {
}
}
- public void createTopic(String topic) {
- int sessionTimeoutMs = 1000;
- ZkClient zkClient = new ZkClient(
- this.zkString, sessionTimeoutMs, sessionTimeoutMs,
- ZKStringSerializer$.MODULE$
- );
- ZkUtils zkUtils = new ZkUtils(zkClient, new ZkConnection(zkString,
sessionTimeoutMs), false);
+ private void createTopic(String topic) {
+ Properties properties = new Properties();
+ properties.setProperty("bootstrap.servers", "localhost:9092");
+ properties.setProperty("key.deserializer",
"org.apache.kafka.common.serialization"
+ + ".StringDeserializer");
+
properties.setProperty("value.deserializer","org.apache.kafka.common.serialization"
Review comment:
Maybe optimizer fixes this automatically, but could we just break the
line at the ',' instead of adding a new concatenation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
