pgaref commented on a change in pull request #1161:
URL: https://github.com/apache/hive/pull/1161#discussion_r452193076
##########
File path:
common/src/java/org/apache/hadoop/hive/common/jsonexplain/DagJsonParserUtils.java
##########
@@ -26,9 +28,13 @@
public class DagJsonParserUtils {
- public static List<String> OperatorNoStats = Arrays.asList(new String[] {
"File Output Operator",
+ private static final List<String> operatorNoStats = Arrays.asList(new
String[] { "File Output Operator",
Review comment:
Well, it kinda needs to be static as Op class is using it directly
within getNameWithOpIdStats method
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -133,6 +134,7 @@ public static void setPerfLogger(PerfLogger
resetPerfLogger) {
* @param callerName the logging object to be used.
* @param method method or ID that identifies this perf log element.
*/
+ @SuppressFBWarnings(value = "NM_METHOD_NAMING_CONVENTION", justification =
"Intended")
public void PerfLogBegin(String callerName, String method) {
Review comment:
Sure, opened HIVE-23823 for tracking this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
