kishendas commented on a change in pull request #1217:
URL: https://github.com/apache/hive/pull/1217#discussion_r453104328
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -1459,6 +1464,22 @@ public Table getTable(final String dbName, final String
tableName, boolean throw
return new Table(tTable);
}
+ /**
+ * Get ValidWriteIdList for the current transaction.
+ * @param dbName
+ * @param tableName
+ * @return
+ * @throws LockException
+ */
+ private ValidWriteIdList getValidWriteIdList(String dbName, String
tableName) throws LockException {
+ ValidWriteIdList validWriteIdList = null;
+ long txnId = SessionState.get().getTxnMgr() != null ?
SessionState.get().getTxnMgr().getCurrentTxnId() : 0;
+ if (txnId > 0) {
Review comment:
Thats taken care in getTableValidWriteIdListWithTxnList() method. It
fails, if the valid_txns_key is not set. Thats why I had to explicitly set this
conf.set(ValidTxnList.VALID_TXNS_KEY,
new ValidReadTxnList(new long[0], new BitSet(), 1000,
Long.MAX_VALUE).writeToString()); in one of the tests, which doesn't go through
Driver flow, but invokes SemanticAnalyzer directly for a transactional table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
