pvary commented on a change in pull request #1222:
URL: https://github.com/apache/hive/pull/1222#discussion_r453498040



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -155,9 +157,11 @@ public int compile(String command, boolean resetTaskIds) {
     }
   }
 
-  // deferClose indicates if the close/destroy should be deferred when the 
process has been
-  // interrupted, it should be set to true if the compile is called within 
another method like
-  // runInternal, which defers the close to the called in that method.
+  /**
+   * @deferClose indicates if the close/destroy should be deferred when the 
process has been interrupted, it should be

Review comment:
       Maybe a correct javadoc comment? The meaning and the usage of 
resetTaskIds is not trivial either




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to