pkumarsinha commented on a change in pull request #1247:
URL: https://github.com/apache/hive/pull/1247#discussion_r456242103
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcrossInstances.java
##########
@@ -944,96 +944,6 @@ public void testIncrementalDumpMultiIteration() throws
Throwable {
Assert.assertEquals(IncrementalLoadTasksBuilder.getNumIteration(),
numEvents);
}
- @Test
- public void testIfCkptAndSourceOfReplPropsIgnoredByReplDump() throws
Throwable {
Review comment:
This was testing that source of replication properties are ignored by
replication while the custom ones are not. Can we retain that part?
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -219,6 +219,11 @@ private void initReplDump(ASTNode ast) throws
HiveException {
" as it is not a source of replication (repl.source.for)");
throw new
SemanticException(ErrorMsg.REPL_DATABASE_IS_NOT_SOURCE_OF_REPLICATION.getMsg());
}
+ if (ReplUtils.isTargetOfReplication(database)) {
+ LOG.error("Cannot dump database " + dbNameOrPattern +
+ " as it is a target of replication (repl.target.for)");
Review comment:
nit: Can accommodate in one line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
