bmaidics commented on a change in pull request #1263:
URL: https://github.com/apache/hive/pull/1263#discussion_r458748457
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -12566,38 +12565,44 @@ void analyzeInternal(ASTNode ast,
Supplier<PlannerContext> pcf) throws SemanticE
createVwDesc.setTablesUsed(getTablesUsed(pCtx));
}
- // 6. Generate table access stats if required
- if (HiveConf.getBoolVar(this.conf,
HiveConf.ConfVars.HIVE_STATS_COLLECT_TABLEKEYS)) {
- TableAccessAnalyzer tableAccessAnalyzer = new TableAccessAnalyzer(pCtx);
- setTableAccessInfo(tableAccessAnalyzer.analyzeTableAccess());
- }
+ //If we're creating views and ColumnAccessInfo is already created, we
should not run these.
+ if(!forViewCreation || getColumnAccessInfo() == null) {
+ // 6. Generate table access stats if required
+ if (HiveConf.getBoolVar(this.conf,
HiveConf.ConfVars.HIVE_STATS_COLLECT_TABLEKEYS)) {
+ TableAccessAnalyzer tableAccessAnalyzer = new
TableAccessAnalyzer(pCtx);
+ setTableAccessInfo(tableAccessAnalyzer.analyzeTableAccess());
+ }
+ AuxOpTreeSignature.linkAuxSignatures(pCtx);
+ // 7. Perform Logical optimization
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Before logical optimization\n" +
Operator.toString(pCtx.getTopOps().values()));
+ }
+ Optimizer optm = new Optimizer();
+ optm.setPctx(pCtx);
+ optm.initialize(conf);
+ pCtx = optm.optimize();
+ if (pCtx.getColumnAccessInfo() != null) {
+ // set ColumnAccessInfo for view column authorization
+ setColumnAccessInfo(pCtx.getColumnAccessInfo());
+ }
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("After logical optimization\n" +
Operator.toString(pCtx.getTopOps().values()));
+ }
- AuxOpTreeSignature.linkAuxSignatures(pCtx);
- // 7. Perform Logical optimization
- if (LOG.isDebugEnabled()) {
- LOG.debug("Before logical optimization\n" +
Operator.toString(pCtx.getTopOps().values()));
- }
- Optimizer optm = new Optimizer();
- optm.setPctx(pCtx);
- optm.initialize(conf);
- pCtx = optm.optimize();
- if (pCtx.getColumnAccessInfo() != null) {
- // set ColumnAccessInfo for view column authorization
- setColumnAccessInfo(pCtx.getColumnAccessInfo());
+ // 8. Generate column access stats if required - wait until column
pruning
Review comment:
Thanks, @jcamachor . Added a more specific comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
