abstractdog commented on a change in pull request #1280:
URL: https://github.com/apache/hive/pull/1280#discussion_r458967592
##########
File path: storage-api/src/java/org/apache/hive/common/util/BloomKFilter.java
##########
@@ -362,16 +378,178 @@ public static void mergeBloomFilterBytes(
// Just bitwise-OR the bits together - size/# functions should be the same,
// rest of the data is serialized long values for the bitset which are
supposed to be bitwise-ORed.
- for (int idx = START_OF_SERIALIZED_LONGS; idx < bf1Length; ++idx) {
+ for (int idx = mergeStart; idx < mergeEnd; ++idx) {
bf1Bytes[bf1Start + idx] |= bf2Bytes[bf2Start + idx];
}
}
+ public static void mergeBloomFilterBytesFromInputColumn(
+ byte[] bf1Bytes, int bf1Start, int bf1Length, long bf1ExpectedEntries,
+ BytesColumnVector inputColumn, int batchSize, boolean selectedInUse,
int[] selected, int numThreads) {
Review comment:
batchSize is not related to the bloom filter instances itself, it
reflects the number of bloom filters in the vectorized row batch...bfSize is
more reminds the byte size of a single bloom filter, which is bf1Length
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
