pvary commented on a change in pull request #1339: URL: https://github.com/apache/hive/pull/1339#discussion_r463166514
########## File path: ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java ########## @@ -680,14 +681,15 @@ public void setBaseAndInnerReader( * @param path The Orc file path we want to get the OrcTail for * @param conf The Configuration to access LLAP * @param cacheTag The cacheTag needed to get OrcTail from LLAP IO cache + * @param fileKey fileId of the Orc file (either the Long fileId of HDFS or the SyntheticFileId) * @return ReaderData object where the orcTail is not null. Reader can be null, but if we had to create * one we return that as well for further reuse. */ - private static ReaderData getOrcTail(Path path, Configuration conf, CacheTag cacheTag) throws IOException { + private static ReaderData getOrcTail(Path path, Configuration conf, CacheTag cacheTag, Object fileKey) throws IOException { Review comment: Maybe 2 different getOrcTail method on the LLAP IO interface? @szlta? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org